-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: note that fork() and exec() are unrelated to Unix system calls, resolves #224 #1718
Conversation
Instead of the "unrelated" disclaimer it's probably better to explain what the difference is. |
Perhaps. I at least initially concluded that including the differences between them is a little like including the differences between JavaScript and Java in the documentation. Despite a similar name, there really is not much of a relationship. And many of the similarities are coincidental. |
Perhaps change "unrelated" to "not similar" or "dissimilar"? |
Note: Note: I don't remember what those system calls do, but something along those lines would be better. |
Yes, that's an improvement. Thanks! I'll keep a watch here and over at #224 and try to pull together the best bits and pieces in the next few hours hopefully... |
OK, I've updated the text based on feedback from @rlidwka, @guss77 and others. What do we think of this? I'm trying to provide more information than just saying they're different, but also trying to keep it succinct.
|
I would be happier if it would include slightly more details, but can live with this as it is. |
I wish such meta-information would be a bit visually distinct from actual behaviour documentation. You don't have to change unless you agree, but I'd like to see these two paragraphs italicized (wrap in |
+1 |
I've italicized it and also prefixed it with "Note:". |
…nix system calls of the same name
Thanks, landed in 86dd244 |
Adds notes about the difference to their POSIX counterparts. PR-URL: nodejs/node#1718 Fixes: nodejs/node#224 Reviewed-By: Roman Reiss <me@silverwind.io>
This is a conservative attempt to resolve #224.